Improved register_globals

pages/advertising/0.php

@@ -20,7 +20,7 @@
 	if($_SESSION['profile']['adadmin'] == 2)
 		$tdcols++;
 
-	if(intval($_REQUEST['approve']) > 0 && $_SESSION['profile']['adadmin'] >= 2)
+	if(array_key_exists('approve',$_REQUEST) && intval($_REQUEST['approve']) > 0 && $_SESSION['profile']['adadmin'] >= 2)
 	{
 		$approve = intval($_REQUEST['approve']);
 		$query = "select * from `advertising` where `id`='$approve' and `expires`='0000-00-00 00:00:00'";
@@ -34,7 +34,7 @@
 			echo "<p>The ad was approved and is now active.</p>\n";
 		}
 	}
-	if(intval($_REQUEST['deactive']) > 0 && $_SESSION['profile']['adadmin'] >= 2)
+	if(array_key_exists('deactive',$_REQUEST) && intval($_REQUEST['deactive']) > 0 && $_SESSION['profile']['adadmin'] >= 2)
 	{
 		$deactive = intval($_REQUEST['deactive']);
 		$query = "select * from `advertising` where `id`='$deactive'";
@@ -65,7 +65,7 @@
 ?>  </tr>
 <?
 	$query = "select *,UNIX_TIMESTAMP(`expires`)-UNIX_TIMESTAMP(NOW()) as `timeleft` from `advertising` where `replaced`=0 ";
-	if($_REQUEST['showall'] != 1)
+	if(!array_key_exists('showall',$_REQUEST) || $_REQUEST['showall'] != 1)
 		$query .= "and `active`=1 having `timeleft` > 0 ";
 	$query .= "order by `id` desc";