From c727bc39d7282abebe75e8cea03779f6330ae158 Mon Sep 17 00:00:00 2001 From: Jan Dittberner Date: Sat, 29 Jul 2023 17:49:55 +0200 Subject: [PATCH] Minor documentation and code improvements - fix name of certificate in README - avoid unneeded variable declaration in internal/services/i18n.go --- README.md | 2 +- internal/services/i18n.go | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index bc03ed1..07f1dc2 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,7 @@ certificates used to verify client certificates to run `cacert-idp`. An easy way to generate server certificate and key for local testing is [`mkcert`](https://github.com/FiloSottile/mkcert/releases). -1. Run `mkcert` to generate `idp.cacert.localhost.pem` and +1. Run `mkcert` to generate `idp.cacert.localhost+1.pem` and `idp.cacert.localhost+1-key.pem`: ```shell diff --git a/internal/services/i18n.go b/internal/services/i18n.go index 40f3c61..d708dac 100644 --- a/internal/services/i18n.go +++ b/internal/services/i18n.go @@ -149,8 +149,6 @@ func (m *MessageCatalog) AddMessages(messages map[string]*i18n.Message) { } func (m *MessageCatalog) LookupErrorMessage(tag, field string, value interface{}, localizer *i18n.Localizer) string { - var message *i18n.Message - message, ok := m.messages[fmt.Sprintf("%s-%s", field, tag)] if !ok { m.logger.Infof("no specific error message %s-%s", field, tag) @@ -200,7 +198,7 @@ func (m *MessageCatalog) LookupMessage( return translation } - m.logger.Warnf("no translation found for %s", id) + m.logger.WithField("id", id).Warn("no translation found for id") return id }