From 474e7717cc73b299c61407267ec4c191436a63dc Mon Sep 17 00:00:00 2001 From: Jan Dittberner Date: Sun, 24 Apr 2022 14:49:17 +0200 Subject: [PATCH] Fix Goland code inspection warnings --- cmd/signer/main.go | 2 +- docs/config.sample.yaml | 2 +- pkg/x509/revoking/revoking_test.go | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/signer/main.go b/cmd/signer/main.go index cbf278d..f9d343e 100644 --- a/cmd/signer/main.go +++ b/cmd/signer/main.go @@ -46,7 +46,7 @@ func main() { log.Printf("cacert-gosigner %s (%s) - built %s\n", version, commit, date) - flag.StringVar(&signerConfigFile, "caconfig", defaultSignerConfigFile, "signer configuration file") + flag.StringVar(&signerConfigFile, "config", defaultSignerConfigFile, "signer configuration file") flag.BoolVar(&showVersion, "version", false, "show version") flag.BoolVar(&setupMode, "setup", false, "setup mode") flag.BoolVar(&verbose, "verbose", false, "verbose output") diff --git a/docs/config.sample.yaml b/docs/config.sample.yaml index 80616f8..2309743 100644 --- a/docs/config.sample.yaml +++ b/docs/config.sample.yaml @@ -67,7 +67,7 @@ CAs: # parent CA, must be any of the other defined CAs parent: "ecc_root_2022" common-name: "CAcert ECC Person CA 2022" - # extended key usage, only makes sense for non root CAs, supported values are + # extended key usage, only makes sense for non-root CAs, supported values are # # - client for client authentication # - code for code signing diff --git a/pkg/x509/revoking/revoking_test.go b/pkg/x509/revoking/revoking_test.go index cfdd086..71a5536 100644 --- a/pkg/x509/revoking/revoking_test.go +++ b/pkg/x509/revoking/revoking_test.go @@ -86,7 +86,7 @@ func (*brokenRepo) StoreRevocation(_ *pkix.RevokedCertificate) error { type brokenRepoNoCrlNumber struct { } -func (b brokenRepoNoCrlNumber) StoreRevocation(certificate *pkix.RevokedCertificate) error { +func (b brokenRepoNoCrlNumber) StoreRevocation(_ *pkix.RevokedCertificate) error { // do nothing return nil } @@ -102,7 +102,7 @@ func (b brokenRepoNoCrlNumber) NextCRLNumber() (*big.Int, error) { type brokenRepoNoRevocations struct { } -func (b brokenRepoNoRevocations) StoreRevocation(certificate *pkix.RevokedCertificate) error { +func (b brokenRepoNoRevocations) StoreRevocation(_ *pkix.RevokedCertificate) error { // do nothing return nil }