Labels Milestones

Improve client certificate issuing #17

Open

jandd wants to merge 1 commits from fix-client-cert-issues into main

pull from: fix-client-cert-issues

merge into: cacert:main

cacert:fix-client-certificate-login

cacert:use-https-for-verification-links

cacert:main

cacert:fix-email-address-maintenance-bug-1543

cacert:fix/bug-1550

Conversation 1 Commits 1 Files Changed 1

jandd commented 2 weeks ago

Owner

• add more comprehensive message when a user does not select an email address or the SSO flag
• fix missing value for coll_found in emailcerts INSERT query
• handle database errors when the emailcerts INSERT query fails

- add more comprehensive message when a user does not select an email address or the SSO flag - fix missing value for coll_found in emailcerts INSERT query - handle database errors when the emailcerts INSERT query fails

jandd added 1 commit 2 weeks ago

9a672e9bf9 Improve client certificate issuing ...

- add more comprehensive message when a user does not select an email address or the SSO flag
- fix missing value for coll_found in emailcerts INSERT query
- handle database errors when the emailcerts INSERT query fails

jandd requested review from dirk 2 weeks ago

jandd requested review from ted 2 weeks ago

knilsson approved these changes 2 weeks ago

Dismissed

knilsson left a comment

On line 256 I see that echo is replaced with ?><p><?= (and the corresponding close tag).
Since I don't know PHP, I have to assume PHP doesn't need the action word echo to print?

On line 256 I see that `echo` is replaced with `?><p><?=` (and the corresponding close tag). Since I don't know PHP, I have to assume PHP doesn't need the action word `echo` to print?

knilsson commented 2 weeks ago

Oh, no! I clicked the wrong button!
I was supposed to only click Comment, and I clicked Approve instead.

Can I walk that back?

Oh, no! I clicked the wrong button! I was supposed to only click *Comment*, and I clicked *Approve* instead. Can I walk that back?

dirk dismissed knilsson’s review 2 weeks ago

Reason:

There is no content yet.

dirk requested review from knilsson 2 weeks ago

bmc approved these changes 2 weeks ago

Reviewers

dirk was requested for review 2 weeks ago

ted was requested for review 2 weeks ago

knilsson was requested for review 2 weeks ago

bmc approved these changes 2 weeks ago

This Pull Request doesn't have enough approvals yet. 1 of 2 approvals granted.

You are not authorized to merge this pull request.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

dirk

ted

knilsson

bmc

Labels

Apply labels

Clear labels

  

bug

Something is not working   

duplicate

This issue or pull request already exists   

enhancement

New feature   

help wanted

Need some help   

invalid

Something is wrong   

question

More information is needed   

wontfix

This won't be fixed

No Label

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

3 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cacert/cacert-webdb#17

Write Preview

Loading…

Cancel

Save

There is no content yet.