Improve client certificate issuing #17

Merged
jandd merged 2 commits from fix-client-cert-issues into main 3 weeks ago
jandd commented 1 month ago
Owner
  • add more comprehensive message when a user does not select an email address or the SSO flag
  • fix missing value for coll_found in emailcerts INSERT query
  • handle database errors when the emailcerts INSERT query fails
- add more comprehensive message when a user does not select an email address or the SSO flag - fix missing value for coll_found in emailcerts INSERT query - handle database errors when the emailcerts INSERT query fails
jandd added 1 commit 1 month ago
9a672e9bf9 Improve client certificate issuing
- add more comprehensive message when a user does not select an email address or the SSO flag
- fix missing value for coll_found in emailcerts INSERT query
- handle database errors when the emailcerts INSERT query fails
jandd requested review from dirk 1 month ago
jandd requested review from ted 1 month ago
knilsson approved these changes 1 month ago
Dismissed
knilsson left a comment

On line 256 I see that echo is replaced with ?><p><?= (and the corresponding close tag).
Since I don't know PHP, I have to assume PHP doesn't need the action word echo to print?

On line 256 I see that `echo` is replaced with `?><p><?=` (and the corresponding close tag). Since I don't know PHP, I have to assume PHP doesn't need the action word `echo` to print?

Oh, no! I clicked the wrong button!
I was supposed to only click Comment, and I clicked Approve instead.

Can I walk that back?

Oh, no! I clicked the wrong button! I was supposed to only click *Comment*, and I clicked *Approve* instead. Can I walk that back?
dirk dismissed knilsson’s review 1 month ago
Reason:
There is no content yet.
dirk requested review from knilsson 1 month ago
bmc approved these changes 1 month ago
dirk approved these changes 3 weeks ago
jandd added 1 commit 3 weeks ago
jandd merged commit 408796eaf0 into main 3 weeks ago
jandd deleted branch fix-client-cert-issues 3 weeks ago

Reviewers

ted was requested for review 1 month ago
knilsson was requested for review 1 month ago
bmc approved these changes 1 month ago
dirk approved these changes 3 weeks ago
The pull request has been merged as 408796eaf0.
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cacert/cacert-webdb#17
Loading…
There is no content yet.