Improve client certificate issuing #17

Merged

jandd merged 2 commits from fix-client-cert-issues into main

2024-05-20 10:46:02 +00:00

jandd commented

2024-05-05 18:14:30 +00:00

Owner

add more comprehensive message when a user does not select an email address or the SSO flag
fix missing value for coll_found in emailcerts INSERT query
handle database errors when the emailcerts INSERT query fails

- add more comprehensive message when a user does not select an email address or the SSO flag - fix missing value for coll_found in emailcerts INSERT query - handle database errors when the emailcerts INSERT query fails

jandd added 1 commit 2024-05-05 18:14:32 +00:00

Improve client certificate issuing 9a672e9bf9

- add more comprehensive message when a user does not select an email address or the SSO flag
- fix missing value for coll_found in emailcerts INSERT query
- handle database errors when the emailcerts INSERT query fails

jandd requested review from dirk 2024-05-05 18:14:39 +00:00

jandd requested review from ted 2024-05-05 18:14:39 +00:00

knilsson approved these changes 2024-05-05 19:39:32 +00:00

Dismissed

knilsson left a comment

Member

On line 256 I see that echo is replaced with ?><p><?= (and the corresponding close tag).
Since I don't know PHP, I have to assume PHP doesn't need the action word echo to print?

On line 256 I see that `echo` is replaced with `?><p><?=` (and the corresponding close tag). Since I don't know PHP, I have to assume PHP doesn't need the action word `echo` to print?

knilsson commented

2024-05-05 19:41:19 +00:00

Member

Oh, no! I clicked the wrong button!
I was supposed to only click Comment, and I clicked Approve instead.

Can I walk that back?

Oh, no! I clicked the wrong button! I was supposed to only click *Comment*, and I clicked *Approve* instead. Can I walk that back?