bug-1562 #23

Open
bmc wants to merge 2 commits from bug-1562 into main
bmc commented 2 months ago

Corrected text.

Corrected text.
bmc added 2 commits 2 months ago
bmc requested review from jandd 2 months ago
bmc requested review from knilsson 2 months ago
jandd commented 2 months ago
Owner

Hi @bmc,

thank you very much to pick up this task (and the other text related ones). For the future please try to write more useful commit messages. It is especially important to reference the addressed issues to allow better traceability to find out why code changes have been introduced by future readers.

This repository has been setup to link to bugs.cacert.org. You can reference issues in the bug tracker like this: #1526

Please read How to Write a Git Commit Message for a general introduction to good commit messages and the Gitea documentation for specifics on referencing bugs.

Kind regards
Jan

Hi @bmc, thank you very much to pick up this task (and the other text related ones). For the future please try to write more useful commit messages. It is especially important to reference the addressed issues to allow better traceability to find out why code changes have been introduced by future readers. This repository has been setup to link to bugs.cacert.org. You can reference issues in the bug tracker like this: #1526 Please read [How to Write a Git Commit Message](https://cbea.ms/git-commit/) for a general introduction to good commit messages and [the Gitea documentation](https://docs.gitea.com/usage/automatically-linked-references) for specifics on referencing bugs. Kind regards Jan
jandd commented 2 months ago
Owner

We have multiple locations for policy documents now:

  1. http://svn.cacert.org/CAcert/Policies/ (the original policy section of the old Subversion repository)
  2. https://code.cacert.org/cacert/cacert-policies (the repository that was migrated from the Subversion variant where @alkas started work on drafting the new CPS)
  3. the copies in this repository (https://code.cacert.org/cacert/cacert-webdb/src/branch/main/www/policy)

We should decide on the canonical location (I suggest 2.) and get rid of the other ones. We could have a release branch in 2. and add this as a submodule in 3. to avoid duplication.

Changes to the policy would then be pull requests in 2. and would be released by merges into the release branch.

Best regards
Jan

We have multiple locations for policy documents now: 1. http://svn.cacert.org/CAcert/Policies/ (the original policy section of the old Subversion repository) 2. https://code.cacert.org/cacert/cacert-policies (the repository that was migrated from the Subversion variant where @alkas started work on drafting the new CPS) 3. the copies in this repository (https://code.cacert.org/cacert/cacert-webdb/src/branch/main/www/policy) We should decide on the canonical location (I suggest 2.) and get rid of the other ones. We could have a release branch in 2. and add this as a submodule in 3. to avoid duplication. Changes to the policy would then be pull requests in 2. and would be released by merges into the release branch. Best regards Jan

I agree that #2 is the best place for the document repo.

I agree that #2 is the best place for the document repo.
knilsson approved these changes 2 months ago
knilsson left a comment

I also agree that it's better to write commit messages in clear text (reason why and what is changed), and then perhaps also refer to the underlying reason for the change.

I also agree that it's better to write commit messages in clear text (reason *why* and *what* is changed), and then perhaps *also* refer to the underlying reason for the change.
bmc commented 1 month ago
Poster

I agree with the choice of #2.

I also understand and agree with your comment about my commit messages, Jan. I generally do not write a lot there since I try to refer to the underlying ticket, but will try to improve in the future.

I agree with the choice of #2. I also understand and agree with your comment about my commit messages, Jan. I generally do not write a lot there since I try to refer to the underlying ticket, but will try to improve in the future.
jandd approved these changes 1 month ago
jandd left a comment
Owner

content approved, the PR should be made against the files in https://code.cacert.org/cacert/cacert-policies too. See the discussion in #23 for reasoning.

content approved, the PR should be made against the files in https://code.cacert.org/cacert/cacert-policies too. See the discussion in https://code.cacert.org/cacert/cacert-webdb/pulls/23#issuecomment-342 for reasoning.
bmc commented 1 month ago
Poster

I have created a PR for the changes to the documents in the Policy repository.

I have created a PR for the changes to the documents in the Policy repository.

Reviewers

knilsson approved these changes 2 months ago
jandd approved these changes 1 month ago
This pull request can be merged automatically.
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cacert/cacert-webdb#23
Loading…
There is no content yet.