cacert/cacert-webdb

Fork 0

bug-1562 #23

Closed

bmc wants to merge 2 commits from bug-1562 into main

bmc commented

2024-06-02 03:12:47 +00:00

Member

Corrected text.

bmc added 2 commits 2024-06-02 03:12:53 +00:00

Modified text as per https://lists.cacert.org/wws/arc/cacert-policy/2020-10/msg00008.html b74b33b446

Corrected text as per https://lists.cacert.org/wws/arc/cacert-policy/2020-10/msg00008.htmlZ a02ce223a0

bmc requested review from jandd 2024-06-02 03:13:46 +00:00

bmc requested review from knilsson 2024-06-02 03:13:47 +00:00

jandd commented

2024-06-02 09:05:23 +00:00

Owner

Hi @bmc,

thank you very much to pick up this task (and the other text related ones). For the future please try to write more useful commit messages. It is especially important to reference the addressed issues to allow better traceability to find out why code changes have been introduced by future readers.

This repository has been setup to link to bugs.cacert.org. You can reference issues in the bug tracker like this: #1526

Please read How to Write a Git Commit Message for a general introduction to good commit messages and the Gitea documentation for specifics on referencing bugs.

Kind regards
Jan

Hi @bmc, thank you very much to pick up this task (and the other text related ones). For the future please try to write more useful commit messages. It is especially important to reference the addressed issues to allow better traceability to find out why code changes have been introduced by future readers. This repository has been setup to link to bugs.cacert.org. You can reference issues in the bug tracker like this: #1526 Please read [How to Write a Git Commit Message](https://cbea.ms/git-commit/) for a general introduction to good commit messages and [the Gitea documentation](https://docs.gitea.com/usage/automatically-linked-references) for specifics on referencing bugs. Kind regards Jan

jandd commented

2024-06-02 09:10:35 +00:00

Owner

We have multiple locations for policy documents now:

http://svn.cacert.org/CAcert/Policies/ (the original policy section of the old Subversion repository)
https://code.cacert.org/cacert/cacert-policies (the repository that was migrated from the Subversion variant where @alkas started work on drafting the new CPS)
the copies in this repository (https://code.cacert.org/cacert/cacert-webdb/src/branch/main/www/policy)

We should decide on the canonical location (I suggest 2.) and get rid of the other ones. We could have a release branch in 2. and add this as a submodule in 3. to avoid duplication.

Changes to the policy would then be pull requests in 2. and would be released by merges into the release branch.

Best regards
Jan

We have multiple locations for policy documents now: 1. http://svn.cacert.org/CAcert/Policies/ (the original policy section of the old Subversion repository) 2. https://code.cacert.org/cacert/cacert-policies (the repository that was migrated from the Subversion variant where @alkas started work on drafting the new CPS) 3. the copies in this repository (https://code.cacert.org/cacert/cacert-webdb/src/branch/main/www/policy) We should decide on the canonical location (I suggest 2.) and get rid of the other ones. We could have a release branch in 2. and add this as a submodule in 3. to avoid duplication. Changes to the policy would then be pull requests in 2. and would be released by merges into the release branch. Best regards Jan

knilsson commented

2024-06-02 10:03:06 +00:00

Member

I agree that #2 is the best place for the document repo.

knilsson approved these changes 2024-06-02 10:05:34 +00:00

knilsson left a comment

Member

I also agree that it's better to write commit messages in clear text (reason why and what is changed), and then perhaps also refer to the underlying reason for the change.

I also agree that it's better to write commit messages in clear text (reason *why* and *what* is changed), and then perhaps *also* refer to the underlying reason for the change.

bmc commented

2024-06-12 13:08:30 +00:00

Author

Member

I agree with the choice of #2.

I also understand and agree with your comment about my commit messages, Jan. I generally do not write a lot there since I try to refer to the underlying ticket, but will try to improve in the future.

I agree with the choice of #2. I also understand and agree with your comment about my commit messages, Jan. I generally do not write a lot there since I try to refer to the underlying ticket, but will try to improve in the future.

jandd approved these changes 2024-06-16 08:46:39 +00:00

jandd left a comment

Owner

content approved, the PR should be made against the files in https://code.cacert.org/cacert/cacert-policies too. See the discussion in #23 (comment) for reasoning.

content approved, the PR should be made against the files in https://code.cacert.org/cacert/cacert-policies too. See the discussion in https://code.cacert.org/cacert/cacert-webdb/pulls/23#issuecomment-342 for reasoning.

bmc commented

2024-06-18 20:06:46 +00:00

Author

Member

I have created a PR for the changes to the documents in the Policy repository.

jandd approved these changes 2024-08-06 20:01:18 +00:00

jandd commented

2024-09-30 09:10:05 +00:00

Owner

The content of this PR has already been included in 2ca4b1aab8

The content of this PR has already been included in 2ca4b1aab868a619a72363f0a629bc229b902d12