cacert/cacert-webdb
9
0
Fork 0
Code Issues Pull requests 3 Projects Releases 4 Wiki Activity

Add a contribution guide #32

Merged
dirk merged 3 commits from add-a-contribution-guide into main 2024-10-17 22:45:51 +00:00
Conversation 2 Commits 3 Files changed 1 +196
jandd commented 2024-10-05 16:26:55 +00:00
Owner
Copy link

This commit adds an initial version of a contribution guide to help new
contributors.

This has been adapted from https://github.com/CAcertOrg/cacert-devel/pull/29
and has been extended to include more information on the actual workflow of
contributions.

This commit adds an initial version of a contribution guide to help new contributors. This has been adapted from https://github.com/CAcertOrg/cacert-devel/pull/29 and has been extended to include more information on the actual workflow of contributions.
jandd added 1 commit 2024-10-05 16:26:55 +00:00 
This commit adds an initial version of a contribution guide to help new
contributors.
jandd requested review from dirk 2024-10-05 16:27:03 +00:00
jandd requested review from bmc 2024-10-05 16:27:04 +00:00
jandd requested review from ted 2024-10-05 16:27:04 +00:00
bmc approved these changes 2024-10-07 00:39:12 +00:00
bmc left a comment
Member
Copy link

Thorough and clear.

Thorough and clear.
dirk reviewed 2024-10-07 21:09:17 +00:00
dirk left a comment
Owner
Copy link

in code snippet at line 80 the closing " is missing
git commit -m "Fix foo in bla subsystem

at line 129 we should mention the "login with CAcert client certificate" / OIDC as way to login to code.cacert.org after setting a password

in code snippet at line 80 the closing " is missing git commit -m "Fix foo in bla subsystem at line 129 we should mention the "login with CAcert client certificate" / OIDC as way to login to code.cacert.org after setting a password
eruedin commented 2024-10-08 06:37:32 +00:00
Member
Copy link

I can't say anything about the code examples. The body text, on the other hand, seems to me to be well thought out and clearly formulated so that even I, as a layman, can understand it.

I can't say anything about the code examples. The body text, on the other hand, seems to me to be well thought out and clearly formulated so that even I, as a layman, can understand it.
jandd added 2 commits 2024-10-08 07:04:11 +00:00
jandd commented 2024-10-08 07:05:02 +00:00
Author
Owner
Copy link

@dirk I added two commits to address your review comments

@dirk I added two commits to address your review comments
jandd requested review from dirk 2024-10-08 07:05:18 +00:00
dirk approved these changes 2024-10-17 22:45:32 +00:00
dirk merged commit c4aa189a0f into main 2024-10-17 22:45:51 +00:00
dirk deleted branch add-a-contribution-guide 2024-10-17 22:45:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ted
bmc
dirk
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cacert/cacert-webdb#32
No description provided.
Delete branch "add-a-contribution-guide"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?