Modified page as per issue: bug-1550. #5

Open

bmc wants to merge 1 commits from fix/bug-1550 into main

bmc commented

Following the request and notes in Bug-1550, implemented the following.

Following the request and notes in Bug-1550, implemented the following.

bmc added 1 commit

c2f3370013 Modified page as per issue: bug-1550.

bmc requested review from jandd

jandd requested review from ted

jandd reviewed

pages/account/3.php

													
				@ -103,4 +31,0 @@

				  </tr>

				<?

				if($_SESSION['profile']['points'] >= 50)

jandd commented

Owner

Is this the only occurrence of the 50 points check? Have you checked whether CommModule/client.pl or at least the place where the INSERT of the CSR occurs make sure that it is not possible to create certificates with the full name of the user?

Is this the only occurrence of the 50 points check? Have you checked whether CommModule/client.pl or at least the place where the INSERT of the CSR occurs make sure that it is not possible to create certificates with the full name of the user?

bmc commented

Poster

My initial checks showed that the rest of the system continued to apply the 50 point check, but I will re-check as you have suggested.

My initial checks showed that the rest of the system continued to apply the 50 point check, but I will re-check as you have suggested.

bmc commented

Poster

I tried to reply to this, but got a CSRF error. Trying again.

I did not change any code in the system outside of page/account/3.php, and all of my examination of other code appears to show that nothing in the tests for 50 points has changed.

I tried to reply to this, but got a CSRF error. Trying again. I did not change any code in the system outside of page/account/3.php, and all of my examination of other code appears to show that nothing in the tests for 50 points has changed.

jandd reviewed

jandd left a comment

Owner

Advice for next time: please keep whitespace changes to a minimum

Advice for next time: please keep whitespace changes to a minimum

Reviewers

jandd was requested for review

ted was requested for review

This pull request has changes conflicting with the target branch.

pages/account/3.php

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.