cacert/cacert-webdb
9
0
Fork 0
Code Issues Pull requests 4 Projects Releases 4 Wiki Activity

Implement warning thresholds for OpenPGP #31

Merged
dirk merged 1 commit from unify-behaviour-of-x509-and-gpg-retries into main 2024-10-07 20:59:41 +00:00
Conversation 1 Commits 1 Files changed 1 +11 -4
jandd commented 2024-10-05 15:25:24 +00:00
Owner
Copy link

This patch fixes https://bugs.cacert.org/view.php?id=1530 by adding the same
warning threshold behaviour for OpenPGP signing requests that exists for
X.509 signing requests.

The warning threshold has been moved to a variable. The SQL statements are
created using an sprintf statement to avoid potential SQL injections that may
get introduced by setting the warning_threshold variable to an invalid valid.

Fixes #1530

This patch fixes https://bugs.cacert.org/view.php?id=1530 by adding the same warning threshold behaviour for OpenPGP signing requests that exists for X.509 signing requests. The warning threshold has been moved to a variable. The SQL statements are created using an sprintf statement to avoid potential SQL injections that may get introduced by setting the warning_threshold variable to an invalid valid. Fixes #1530
jandd added 1 commit 2024-10-05 15:25:24 +00:00 
This patch fixes https://bugs.cacert.org/view.php?id=1530 by adding the same
warning threshold behaviour for OpenPGP signing requests that exists for
X.509 signing requests.

The warning threshold has been moved to a variable. The SQL statements are
created using an sprintf statement to avoid potential SQL injections that may
get introduced by setting the warning_threshold variable to an invalid valid.

Fixes #1530
jandd commented 2024-10-05 15:26:25 +00:00
Author
Owner
Copy link

This pull request is a replacement for https://github.com/CAcertOrg/cacert-devel/pull/27 which has been commented by @bmc in https://bugs.cacert.org/view.php?id=1530#c6016

I would like to merge this to close that long open bug.

This pull request is a replacement for https://github.com/CAcertOrg/cacert-devel/pull/27 which has been commented by @bmc in https://bugs.cacert.org/view.php?id=1530#c6016 I would like to merge this to close that long open bug.
jandd requested review from dirk 2024-10-05 15:26:34 +00:00
jandd requested review from bmc 2024-10-05 15:26:34 +00:00
jandd requested review from ted 2024-10-05 15:26:35 +00:00
bmc approved these changes 2024-10-07 00:32:40 +00:00
bmc left a comment
Member
Copy link

As described. Looks good to me.

As described. Looks good to me.
dirk approved these changes 2024-10-07 20:58:38 +00:00
dirk merged commit 12fdf40cda into main 2024-10-07 20:59:41 +00:00
dirk deleted branch unify-behaviour-of-x509-and-gpg-retries 2024-10-07 20:59:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ted
bmc
dirk
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cacert/cacert-webdb#31
No description provided.
Delete branch "unify-behaviour-of-x509-and-gpg-retries"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?