Revised commit of 3.php to limit it to the bare minimum. #33
knilsson
jandd
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: cacert/cacert-webdb#33
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/bug-1550a"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The selection of Root Certicate type has been removed and only the Type 3
will be generated.
This will be much easier to examine and approve than previous fixes.
This looks good to me. Hiding the ability to choose the wrong certificate, and defaulting to the correct certificate. Also clearly mentioning that both root certs are needed when using the user certificate.
the coding itself is as expected ...
... BUT ...
(1) first the CPS has to be changed ...
(2) we have to allow non-assured members to use class-3 certificates
(3) the translation has to be updated before this patch is installed
therefore:
yes ... approved from coding site
no ... to apply this update before (1) to (3) are finished
@ -40,9 +40,6 @@ my $paranoid=1;my $debug=0;# number of attempts before giving upplease do not revert the changes in client.pl, they where required improvements
The changes were implemented in #31
@ -106,3 +106,1 @@<input type="radio" id="root1" name="rootcert" value="1" /> <label for="root1"><?=_("Sign by class 1 root certificate")?></label><br /><input type="radio" id="root2" name="rootcert" value="2" checked="checked"/> <label for="root2"><?= _("Sign by class 3 root certificate") ?></label><br/><?= str_replace("\n", "<br />\n", wordwrap(_("Please note: If you use a certificate signed by the class 3 root, the class 3 root certificate needs to be imported into your email program as well as the class 1 root certificate so your email program can build a full trust path chain."), 125 ) ) ?><!-- <input type="radio" id="root1" name="rootcert" value="1" /> <label for="root1"><?=_("Sign by class 1 root certificate")?></label><br /> -->please remove the line instead of commenting it. It is no longer required and we have git to keep the historic version.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.